Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration form validators don't work #2958

Closed
shreyamalviya opened this issue Feb 9, 2023 · 0 comments
Closed

Configuration form validators don't work #2958

shreyamalviya opened this issue Feb 9, 2023 · 0 comments
Assignees
@VakarisZ
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Medium UI User Interface

Comments

@shreyamalviya
Copy link
Contributor

shreyamalviya commented Feb 9, 2023 •
edited
Loading

Although we don't have strict validation in the configuration (#1301), the UI is supposed to print a red warning message if invalid configuration options are provided (see this for an example).

This isn't happening anymore. No red warning message is printed.

image
image

Refer to this to fix.
@shreyamalviya shreyamalviya added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. UI User Interface Impact: Medium Complexity: Low labels Feb 9, 2023
@VakarisZ VakarisZ mentioned this issue Feb 9, 2023
Merged
7 tasks
mssalvatore added a commit that referenced this issue Feb 9, 2023
@mssalvatore
Merge branch '2958-ui-input-validation-fix' into release/2.0.0
01a8683 
Issue #2958
PR #2964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VakarisZ VakarisZ

Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Medium UI User Interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mssalvatore @VakarisZ @shreyamalviya