Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the ZeroLogon exploiter to a plugin #3164

Closed
13 of 14 tasks
mssalvatore opened this issue Mar 28, 2023 · 0 comments · Fixed by #3295
Closed
13 of 14 tasks

Migrate the ZeroLogon exploiter to a plugin #3164

mssalvatore opened this issue Mar 28, 2023 · 0 comments · Fixed by #3295

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Mar 28, 2023

Description

Replace the hard-coded ZeroLogon exploiter with ZeroLogon exploiter plugin.

Use the SMBExploiter and/or HadoopExploiter as templates.

A note on scope

The ZeroLogon exploiter is large and complex. There's lots of room for improvement in its code quality, however, the time it would take to reimplement it is probably not worth the value on such an old vulnerability. We can make small improvements, but should avoid getting sucked into a large refactor of this exploiter. In other words, if we can simply wrap the existing exploiter with a plugin.py, let's do that (as much as is possible).

Tasks

  • options (pydantic) (0d) @cakekoa
    • determine what options ZeroLogon should have
    • create a pydantic model for ZeroLogon options
    • Create plugin manifest
    • Create config schema
  • Create a Pipfile for dependencies (0d) @mssalvatore
  • Add a jenkins job to build the plugin (0.25d) @cakekoa
    • Update the island build jobs on Jenkins to copy the artifacts from the ZeroLogon plugin build job
  • exploiter (0d) @cakekoa
    • Check any preconditions
    • Don't forget to add MITRE tags
  • Update ETE test configurations and run tests (0d) @cakekoa
  • Remove the hard-coded ZeroLogon plugin (0d) @mssalvatore
  • Test and fix bugs (0.5d) @shreyamalviya
@mssalvatore mssalvatore added this to the v2.2.0 milestone Mar 28, 2023
@cakekoa cakekoa self-assigned this May 1, 2023
@cakekoa cakekoa mentioned this issue May 1, 2023
10 tasks
mssalvatore added a commit that referenced this issue May 1, 2023
mssalvatore added a commit that referenced this issue May 1, 2023
@cakekoa cakekoa mentioned this issue May 1, 2023
10 tasks
@mssalvatore mssalvatore reopened this May 3, 2023
@shreyamalviya shreyamalviya mentioned this issue May 3, 2023
10 tasks
mssalvatore added a commit that referenced this issue May 3, 2023
mssalvatore added a commit that referenced this issue May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants