Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent: Add content to ransomware README.txt file #1276

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

mssalvatore
Copy link
Collaborator

What does this PR do?

Issue #1244

Replaces the placeholder content in the ransomware README.txt file with cool ASCII art and useful information.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests

  • If applicable, add screenshots or log transcripts of the feature working

Screenshots

image

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1276 (a45900a) into develop (00426c6) will decrease coverage by 29.73%.
The diff coverage is 26.29%.

❗ Current head a45900a differs from pull request most recent head 32a0a41. Consider uploading reports for the commit 32a0a41 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1276       +/-   ##
============================================
- Coverage    59.89%   30.15%   -29.74%     
============================================
  Files          147      445      +298     
  Lines         4787    13353     +8566     
============================================
+ Hits          2867     4027     +1160     
- Misses        1920     9326     +7406     
Impacted Files Coverage Δ
monkey/common/cloud/instance.py 66.66% <ø> (ø)
monkey/common/cmd/aws/aws_cmd_result.py 0.00% <0.00%> (ø)
monkey/common/cmd/aws/aws_cmd_runner.py 0.00% <0.00%> (ø)
monkey/common/cmd/cmd.py 0.00% <0.00%> (ø)
monkey/common/cmd/cmd_result.py 0.00% <0.00%> (ø)
monkey/common/cmd/cmd_runner.py 0.00% <0.00%> (ø)
monkey/common/cmd/cmd_status.py 0.00% <0.00%> (ø)
monkey/common/common_consts/__init__.py 100.00% <ø> (ø)
monkey/common/common_consts/network_consts.py 0.00% <0.00%> (ø)
monkey/common/network/segmentation_utils.py 100.00% <ø> (ø)
... and 538 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f027ad6...32a0a41. Read the comment docs.

@mssalvatore mssalvatore requested a review from ofriz June 28, 2021 23:04
:dmmd:

Infection Monkey is an open-source breach and attack simulation (BAS) platform. The files in this
directory have been manipulated as part of a ransomware simulation. This is NOT a ransomware attack.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of is a ransomware attack or at least we're trying to get as close as possible to one. Maybe rephrase to This is NOT a real ransomware attack.?

Comment on lines +1 to +8
██████████ ██ █████ ███████████ ███
░░███░░░░███ ███ ░░███ ░░███░░░░░███ ░░░
░███ ░░███ ██████ ████████ ░░░ ███████ ░███ ░███ ██████ ████████ ████ ██████
░███ ░███ ███░░███░░███░░███ ░░░███░ ░██████████ ░░░░░███ ░░███░░███ ░░███ ███░░███
░███ ░███░███ ░███ ░███ ░███ ░███ ░███░░░░░░ ███████ ░███ ░███ ░███ ░███ ░░░
░███ ███ ░███ ░███ ░███ ░███ ░███ ███ ░███ ███░░███ ░███ ░███ ░███ ░███ ███
██████████ ░░██████ ████ █████ ░░█████ █████ ░░████████ ████ █████ █████░░██████
░░░░░░░░░░ ░░░░░░ ░░░░ ░░░░░ ░░░░░ ░░░░░ ░░░░░░░░ ░░░░ ░░░░░ ░░░░░ ░░░░░░
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Infection Monkey was here" would be better? In my mind, infection monkey spreading across the network is a valid reason to panic :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble getting "Infection Monkey was here" in a readable font. Anything easily readable comes out too large.

Since this PR has approvals, I'm going to merge it without this change. I'll have our marketing team look at this (and our documentation) before we release. They'll probably come up with something better.

@mssalvatore mssalvatore force-pushed the ransomware-readme-behavior branch from 870fae8 to 92be6e7 Compare June 29, 2021 15:04
@mssalvatore mssalvatore force-pushed the ransomware-readme-content branch from 6cba29c to a45900a Compare June 29, 2021 15:12
Base automatically changed from ransomware-readme-behavior to develop June 29, 2021 15:32
@mssalvatore mssalvatore force-pushed the ransomware-readme-content branch from a45900a to 60d8c1a Compare June 29, 2021 15:47
@mssalvatore mssalvatore force-pushed the ransomware-readme-content branch from 60d8c1a to 32a0a41 Compare June 29, 2021 15:51
@mssalvatore mssalvatore merged commit 32a0a41 into develop Jun 29, 2021
@mssalvatore mssalvatore deleted the ransomware-readme-content branch June 29, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants