-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Island: Add npm ci to deplyoment script for windows #1281
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1281 +/- ##
========================================
Coverage 30.11% 30.11%
========================================
Files 445 445
Lines 13347 13347
========================================
Hits 4020 4020
Misses 9327 9327 Continue to review full report at Codecov.
|
@@ -242,6 +242,7 @@ function Deploy-Windows([String] $monkey_home = (Get-Item -Path ".\").FullName, | |||
"Updating npm" | |||
Push-Location -Path (Join-Path -Path $monkey_home -ChildPath $MONKEY_ISLAND_DIR | Join-Path -ChildPath "\cc\ui") | |||
& npm update | |||
& npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VakarisZ I'm not very familiar with npm
. Should we be using npm install
instead since this is a development environment? Do we need do npm update
if we do npm ci
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm ci
is similar with npm install
https://docs.npmjs.com/cli/v6/commands/npm-ci . And npm install
didn't help solving the issue with the dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so It appears that the package-lock.json and package.json after deployment are changing which is causing the problem above.
The steps were:
- Run
deploy_linux.sh
- Try to run the monkey_island and see that the frontend is not build
- Check git status to see that
package.json
andpackage-lock.json
are changed.
It is resolved by:
Checkout the changes and run npm ci
and npm run dist
to build the frontend.
The solution is to checkout the files mention above and run |
What does this PR do?
Fixes npm issue in deployment script fro windows.
Add any further explanations here.
PR Checklist
Testing Checklist
Explain Changes
Are the commit messages enough? If not, elaborate.