-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ransomware config UI description #1286
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1286 +/- ##
========================================
Coverage 30.68% 30.68%
========================================
Files 449 449
Lines 13470 13470
========================================
Hits 4133 4133
Misses 9337 9337
Continue to review full report at Codecov.
|
"description": "This page allows you to configure the Infection Monkey to execute a ransomware " | ||
"simulation. The Infection Monkey is capable of simulating a ransomware attack on your network " | ||
"using a set of configurable behaviors. A number of precautions have been taken to ensure that " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is not excessive info since the user is in the ransomware tab under the ransomware title, so it should be obvious that he's configuring ransomware simulation here. The fact that it's safe to run in production environment can be said about almost every field in configuration and monkey in general. The only thing I see as a must is a link to the documentation hub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done some thinking about it. I haven't really been able to come up with a better short description of what these configuration options are. I think it's worth the note about it being "safe", so people don't panic when they see "ransomware."
As we continue to work on this capability, we can revisit this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but it's worth the extra 5mins of thought to make sure that the config is both readable and intuitive without being a burden to go through.
What does this PR do?
Adds a description and link to documentation to the ransomware configuration UI.
Issue #1239
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Screenshots