Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internet access check #1420

Merged
merged 5 commits into from
Aug 20, 2021
Merged

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Aug 20, 2021

What does this PR do?

Fixes #1402

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running blackbox tests and a custom test to verify reports render correctly.

  • If applicable, add screenshots or log transcripts of the feature working

Screenshots

Before

bb_before

After

bb_after

@mssalvatore mssalvatore force-pushed the remove-internet-access-check branch from 8358d27 to cf73d11 Compare August 20, 2021 13:30
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1420 (cf73d11) into develop (8e9f564) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1420   +/-   ##
========================================
  Coverage    40.07%   40.07%           
========================================
  Files          465      465           
  Lines        13845    13831   -14     
========================================
- Hits          5548     5543    -5     
+ Misses        8297     8288    -9     
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 64.74% <ø> (-0.26%) ⬇️
monkey/infection_monkey/network/info.py 24.70% <ø> (-0.56%) ⬇️
monkey/monkey_island/cc/models/monkey.py 91.11% <ø> (-0.10%) ⬇️
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)
monkey/infection_monkey/control.py 22.27% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9f564...cf73d11. Read the comment docs.

Copy link
Contributor

@shreyamalviya shreyamalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@mssalvatore mssalvatore merged commit 198fbd6 into develop Aug 20, 2021
@mssalvatore mssalvatore deleted the remove-internet-access-check branch October 14, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused "internet_access" checks cause annoying delays
3 participants