Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom singleton mutex name option #1589

Merged
merged 4 commits into from
Nov 16, 2021

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

#1537

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1589 (f90434d) into develop (6f4c671) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1589      +/-   ##
===========================================
- Coverage    44.76%   44.75%   -0.01%     
===========================================
  Files          474      474              
  Lines        13856    13855       -1     
===========================================
- Hits          6202     6201       -1     
  Misses        7654     7654              
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 61.71% <ø> (-0.30%) ⬇️
monkey/infection_monkey/system_singleton.py 0.00% <0.00%> (ø)
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4c671...f90434d. Read the comment docs.

@shreyamalviya shreyamalviya force-pushed the 1537-constant-singleton-mutex-name branch from 452b1f0 to f90434d Compare November 16, 2021 06:05
@shreyamalviya shreyamalviya merged commit ada9237 into develop Nov 16, 2021
@shreyamalviya shreyamalviya deleted the 1537-constant-singleton-mutex-name branch November 16, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants