Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scoutsuite #1699

Merged
merged 31 commits into from
Feb 9, 2022
Merged

Remove scoutsuite #1699

merged 31 commits into from
Feb 9, 2022

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Feb 7, 2022 •
edited
Loading

What does this PR do?

Fixes #1669

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running on AWS, cloud run and from the Island. Some exceptions were found; discussion ongoing on Slack.

  • If applicable, add screenshots or log transcripts of the feature working

VakarisZ
VakarisZ reviewed Feb 7, 2022
View reviewed changes
monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunOptions.js Outdated
{ips: ips, setComponent: setComponent})
}}/>
}
{isNotRansomware(props.islandMode) && <AWSRunButton setComponent={setComponent}/> }
Copy link
Contributor

@VakarisZ VakarisZ Feb 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isNotRansomwareMode or showRunOnAwsButton are better names IMO, not important though

VakarisZ
VakarisZ approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to make sure we can run on remote AWS machines without errors, export findings and that ZT report is showing up OK.

ilija-lazoroski
ilija-lazoroski approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just build the binaries and retest based on Vakaris comment.

mssalvatore and others added 27 commits February 9, 2022 14:27
@mssalvatore @shreyamalviya
Agent: Remove ScoutSuite system info collector
16bb13f
@mssalvatore @shreyamalviya
Common: Remove ScoutSuiteScanError
2f397ad
@mssalvatore @shreyamalviya
Docs: Remove references to ScoutSuite
c68adf4
@mssalvatore @shreyamalviya
Agent: Remove ScoutSuiteTelem
9e9e8be
@mssalvatore @shreyamalviya
Island: Remove ScoutSuite telemetry processing
fe459dd
@mssalvatore @shreyamalviya
Common: Remove ScoutSuite telemetry category
5423bbb
@mssalvatore @shreyamalviya
Island: Remove ScoutSuiteRuleService
d294779
@mssalvatore @shreyamalviya
Common: Remove RulePathCreatorNotFound Exception
7498cbb
@mssalvatore @shreyamalviya
Island: Remove ScoutSuiteZTFindingService
2728404
@mssalvatore @shreyamalviya
Island: Remove ScoutSuite rule path creators
75f23b6
@mssalvatore @shreyamalviya
Island: Remove scoutsuite findings and rules
a35f141
@mssalvatore @shreyamalviya
Island: Remove ScoutSuiteRawDataService
039a62a
@mssalvatore @shreyamalviya
Island: Remove ScoutSuiteFinding
b23360d
@mssalvatore @shreyamalviya
UT: Fix test_principle_service tests
788641b 
And modify data in test_pillar_service.py accordingly
@shreyamalviya
UT: Modify comments in test_pillar_service.py to be accurate
894250f
@shreyamalviya
UT: Remove Scoutsuite's unit tests
c2c609a
@shreyamalviya
UI: Remove Scoutsuite option from Run Monkey page
c357ee4
@shreyamalviya
UI: Rename function in RunOptions.js more appropriately
88f156e
@shreyamalviya
Island: Remove endpoints/resources/services related to Scoutsuite
7243406
@shreyamalviya
Common: Remove Scoutsuite constants
cb6bafa
@shreyamalviya
Project: Remove removed Scoutsuite constants from Vulture allowlist
9dc0a6e
@shreyamalviya
UI: Remove Scoutsuite reporting
c0d1df6
@mssalvatore @shreyamalviya
Agent: Remove disused is_running_on_island() function
c1c04d8
@mssalvatore @shreyamalviya
Common: Remove disused get_host_from_network_location() function
fcbdb5a
@mssalvatore @shreyamalviya
Changelog: Add entry for ScoutSuite removal
9a88ac3
@ilija-lazoroski @shreyamalviya
Agent: Remove print statement for policyuniverse in monkey spec
c458f93
@shreyamalviya
UI: Rename function to make more sense
c129f80
@shreyamalviya shreyamalviya force-pushed the 1669-remove-scoutsuite-integration branch from 0d2009b to 30bbfec Compare February 9, 2022 09:05
@shreyamalviya shreyamalviya merged commit 5a64db4 into agent-refactor Feb 9, 2022
@mssalvatore mssalvatore deleted the 1669-remove-scoutsuite-integration branch February 23, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

@VakarisZ VakarisZ VakarisZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreyamalviya @ilija-lazoroski @VakarisZ @mssalvatore