-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify SSH exploit #1727
Modify SSH exploit #1727
Conversation
5eb5e0c
to
c17af16
Compare
e1e8cfb
to
681e119
Compare
* Remove credential hashes from logs * Get rid of config and use brute_force utils * Use telemetry messenger to send attack telemetries * Zerologon and Powershell needs to be revised based on UT
5d98628
to
cd38b58
Compare
a703cbe
to
fa26311
Compare
fa26311
to
03178b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also get rid of any stale code in HostExploiter
now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating a dictionary exploit_result
and passing everything to ExploiterResultData
one by one, we could use default values for named tuples, and simply instantiate it as self.exploit_result = ExploiterResultData()
in pre_exploit()
. Then, we could simply modify that object instead of having a dictionary tracking the exact same values.
…value in SSH exploiter
@shreyamalviya NamedTuples are immutable. We could convert it to a dataclass. The conversion will happen sooner or later, I don't much mind if it happens here or down the road. |
@mssalvatore I'll do it now so we won't have to modify the exploiters again. |
and modify HostExploiter and the SSH exploiter accordingly
What does this PR do?
Modify SSH exploiter, related to #1605.
PR Checklist
Is the TravisCI build passing?Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?