Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1996 agent worm config decouple #2016

Merged
merged 17 commits into from
Jun 15, 2022
Merged

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Mitigates the coupling of agent codebase to current_server property in worm config, by using server address from control channel and control client #1996

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests
    Tested by running manual test, infecting machines

  • If applicable, add screenshots or log transcripts of the feature working

@VakarisZ VakarisZ requested a review from mssalvatore June 14, 2022 09:38
@VakarisZ VakarisZ mentioned this pull request Jun 14, 2022
8 tasks
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2016 (5ff617b) into develop (133f7f5) will increase coverage by 0.05%.
The diff coverage is 36.36%.

@@             Coverage Diff             @@
##           develop    #2016      +/-   ##
===========================================
+ Coverage    56.63%   56.69%   +0.05%     
===========================================
  Files          463      463              
  Lines        12894    12883      -11     
===========================================
+ Hits          7303     7304       +1     
+ Misses        5591     5579      -12     
Impacted Files Coverage Δ
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)
monkey/infection_monkey/control.py 32.74% <36.36%> (+2.49%) ⬆️
monkey/infection_monkey/master/control_channel.py 34.14% <66.66%> (-0.86%) ⬇️
...ection_monkey/post_breach/custom_pba/custom_pba.py 63.33% <66.66%> (ø)
monkey/infection_monkey/config.py 31.81% <100.00%> (-2.97%) ⬇️
monkey/infection_monkey/telemetry/base_telem.py 100.00% <100.00%> (ø)
monkey/infection_monkey/telemetry/tunnel_telem.py 100.00% <100.00%> (ø)
.../unit_tests/infection_monkey/telemetry/conftest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133f7f5...5ff617b. Read the comment docs.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small changes in the unit tests

VakarisZ and others added 2 commits June 14, 2022 16:50
Bugs happened because of incorrect indentation in the recent refactoring attempting to remove worm config dependency
@mssalvatore mssalvatore merged commit ad1928d into develop Jun 15, 2022
@mssalvatore mssalvatore deleted the 1996-agent-worm-config-decouple branch June 15, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants