-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1996 agent worm config decouple #2016
Conversation
This is done to refactor ControlClient from a global
* Workaround global class attribute
Codecov Report
@@ Coverage Diff @@
## develop #2016 +/- ##
===========================================
+ Coverage 56.63% 56.69% +0.05%
===========================================
Files 463 463
Lines 12894 12883 -11
===========================================
+ Hits 7303 7304 +1
+ Misses 5591 5579 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small changes in the unit tests
monkey/tests/unit_tests/infection_monkey/post_breach/actions/test_users_custom_pba.py
Outdated
Show resolved
Hide resolved
Bugs happened because of incorrect indentation in the recent refactoring attempting to remove worm config dependency
What does this PR do?
Mitigates the coupling of agent codebase to
current_server
property in worm config, by using server address from control channel and control client #1996Add any further explanations here.
PR Checklist
Testing Checklist