Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Set terminate signal for duplicate agents #3058

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 6, 2023

What does this PR do?

Fixes part of #2817.

If more than one agent is running on a given machine, the first agent shall be allowed to run, and the rest shall be given a terminate signal.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests

  • If applicable, add screenshots or log transcripts of the feature working

If more than one agent is running on a given machine, the first agent
shall be allowed to run, and the rest shall be given a terminate signal.
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (b454c88) 67.26% compared to head (3c66438) 67.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3058      +/-   ##
===========================================
+ Coverage    67.26%   67.28%   +0.02%     
===========================================
  Files          439      439              
  Lines        12636    12644       +8     
===========================================
+ Hits          8499     8507       +8     
  Misses        4137     4137              
Impacted Files Coverage Δ
...monkey_island/cc/services/agent_signals_service.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ilija-lazoroski ilija-lazoroski force-pushed the 2817-set-terminate-signal-for-duplicate-agents branch from 9393ff6 to 61e4da3 Compare March 7, 2023 11:14
@mssalvatore mssalvatore force-pushed the 2817-set-terminate-signal-for-duplicate-agents branch 2 times, most recently from 85b8779 to 3c66438 Compare March 7, 2023 13:30
@mssalvatore mssalvatore merged commit fc8d9ba into develop Mar 7, 2023
@mssalvatore mssalvatore deleted the 2817-set-terminate-signal-for-duplicate-agents branch March 7, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants