Feature/check for updates #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add routing to update resource Split app initializing to functions
acepace
reviewed
Apr 22, 2019
| "server_config": "standard" | ||
| "server_config": "standard", | ||
| "deployment": "develop", | ||
| "monkey_version": "1.6.2" |
There was a problem hiding this comment.
Add newline at end of file?
acepace
reviewed
Apr 22, 2019
| if res is False: | ||
| return res | ||
|
|
||
| [int(x) for x in res.split('.')] # raises value error if version is invalid format |
There was a problem hiding this comment.
We can't return new dev version this way? we're forced to return int.int.int.int...
There was a problem hiding this comment.
No such thing as "new dev version"
| super(VersionUpdate, self).__init__() | ||
|
|
||
| @jwt_required() | ||
| def get(self): |
There was a problem hiding this comment.
I don't think this should be jwt_required
Add new line at end of server_config.json
danielguardicore
approved these changes
Apr 23, 2019
| @@ -13,6 +13,7 @@ class Environment(object): | |||
| _MONGO_URL = os.environ.get("MONKEY_MONGO_URL", "mongodb://localhost:27017/monkeyisland") | |||
| _DEBUG_SERVER = False | |||
| _AUTH_EXPIRATION_TIME = timedelta(hours=1) | |||
| _MONKEY_VERSION = "1.6.2" | |||
There was a problem hiding this comment.
Why is it hardcoded here?
add requests to requirements
# Conflicts: # monkey/monkey_island/cc/app.py # monkey/monkey_island/requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature / Fixes