Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3078 otp generator #3187

Merged
merged 10 commits into from
Apr 4, 2023
Merged

3078 otp generator #3187

merged 10 commits into from
Apr 4, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 31, 2023

What does this PR do?

Fixes part of #3078 by adding a class that generates OTPs.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@e3f04ea). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3187   +/-   ##
==========================================
  Coverage           ?   72.81%           
==========================================
  Files              ?      471           
  Lines              ?    13450           
  Branches           ?        0           
==========================================
  Hits               ?     9793           
  Misses             ?     3657           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cakekoa cakekoa force-pushed the 3078-otp-generator branch from 54e0551 to 708b18e Compare April 3, 2023 20:14
@cakekoa cakekoa marked this pull request as ready for review April 3, 2023 20:42
@shreyamalviya shreyamalviya mentioned this pull request Apr 4, 2023
10 tasks
AuthenticationServiceOTPGenerator
@mssalvatore mssalvatore merged commit 9340ae9 into develop Apr 4, 2023
@mssalvatore mssalvatore deleted the 3078-otp-generator branch April 4, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants