-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3078 otp generator #3187
Merged
Merged
3078 otp generator #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3187 +/- ##
==========================================
Coverage ? 72.81%
==========================================
Files ? 471
Lines ? 13450
Branches ? 0
==========================================
Hits ? 9793
Misses ? 3657
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mssalvatore
requested changes
Apr 3, 2023
monkey/monkey_island/cc/services/authentication_service/otp/otp_generator.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/otp/otp_generator.py
Outdated
Show resolved
Hide resolved
54e0551
to
708b18e
Compare
mssalvatore
requested changes
Apr 3, 2023
monkey/monkey_island/cc/services/authentication_service/otp_generator.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/authentication_facade.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/authentication_facade.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/otp_generator.py
Outdated
Show resolved
Hide resolved
monkey/tests/unit_tests/monkey_island/cc/services/authentication_service/test_otp_generator.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/authentication_otp_generator.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/authentication_otp_generator.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/i_otp_generator.py
Show resolved
Hide resolved
AuthenticationServiceOTPGenerator
mssalvatore
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #3078 by adding a class that generates OTPs.
PR Checklist
Testing Checklist