UI: Generate manual run commands with OTP #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
reviewed
Apr 4, 2023
.../monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunManually/LocalManualRunOptions.js
Show resolved
Hide resolved
cakekoa
force-pushed
the
3078-manual-run-refresh-button
branch
from
8472067 to
2d86ab5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3195 +/- ##
==========================================
Coverage ? 73.05%
==========================================
Files ? 471
Lines ? 13585
Branches ? 0
==========================================
Hits ? 9924
Misses ? 3661
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cakekoa
force-pushed
the
3078-manual-run-refresh-button
branch
from
458e546 to
0583355
Compare
mssalvatore
reviewed
Apr 5, 2023
.../monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunManually/LocalManualRunOptions.js
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
67
| function generateCommands() { | ||
| if (osType === OS_TYPES.WINDOWS_64) { | ||
| return [{type: 'Powershell', command: GenerateLocalWindowsPowershell(selectedIp, customUsername)}] | ||
| return [{type: 'Powershell', command: GenerateLocalWindowsPowershell(selectedIp, customUsername, otp)}] | ||
| } else { | ||
| return [{type: 'CURL', command: GenerateLocalLinuxCurl(selectedIp, customUsername)}, | ||
| {type: 'WGET', command: GenerateLocalLinuxWget(selectedIp, customUsername)}] | ||
| return [{type: 'CURL', command: GenerateLocalLinuxCurl(selectedIp, customUsername, otp)}, | ||
| {type: 'WGET', command: GenerateLocalLinuxWget(selectedIp, customUsername, otp)}] | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we want to hide the OTP and replace it with '*'?
shreyamalviya
approved these changes
Apr 6, 2023
.../monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunManually/LocalManualRunOptions.js
Outdated
Show resolved
Hide resolved
.../monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunManually/LocalManualRunOptions.js
Outdated
Show resolved
Hide resolved
.../monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunManually/LocalManualRunOptions.js
Outdated
Show resolved
Hide resolved
mssalvatore
approved these changes
Apr 6, 2023
mssalvatore
force-pushed
the
3078-manual-run-refresh-button
branch
from
0fbe7b8 to
81da708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #3078.
PR Checklist
Testing Checklist