Implement Agent login via OTP #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
requested changes
Apr 5, 2023
monkey/monkey_island/cc/services/authentication_service/flask_resources/agent_otp_login.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/flask_resources/agent_otp_login.py
Outdated
Show resolved
Hide resolved
mssalvatore
requested changes
Apr 5, 2023
monkey/monkey_island/cc/services/authentication_service/flask_resources/agent_otp_login.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/flask_resources/agent_otp_login.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/flask_resources/agent_otp_login.py
Outdated
Show resolved
Hide resolved
mssalvatore
force-pushed
the
3078-implement-AgentOTPLogin-resource
branch
from
9cc0376 to
f42db0e
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3196 +/- ##
===========================================
+ Coverage 72.93% 72.97% +0.04%
===========================================
Files 471 471
Lines 13496 13538 +42
===========================================
+ Hits 9843 9880 +37
- Misses 3653 3658 +5 see 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mssalvatore
reviewed
Apr 5, 2023
| return make_response(f"Missing argument {err}", HTTPStatus.BAD_REQUEST) | ||
| except TypeError: | ||
| return make_response("Could not parse the login request", HTTPStatus.BAD_REQUEST) | ||
|
|
There was a problem hiding this comment.
TODO: Verify that AgentID exists in the agent repository.
There was a problem hiding this comment.
We can't do that because Agent registration happens after the login.
There was a problem hiding this comment.
Good call. We'll need to add a cleanup step to ensure that if agents fail to register their users get cleaned up.
shreyamalviya
force-pushed
the
3078-implement-AgentOTPLogin-resource
branch
from
c231470 to
cedef47
Compare
shreyamalviya
force-pushed
the
3078-implement-AgentOTPLogin-resource
branch
from
cedef47 to
93fc73a
Compare
mssalvatore
reviewed
Apr 5, 2023
monkey/monkey_island/cc/services/authentication_service/flask_resources/agent_otp_login.py
Outdated
Show resolved
Hide resolved
It's probably a bad idea to include certain whitespace characters in the password field. Even though this password should never be used, I'm not sure whether or not Flask Security or Flask Login would be expecting such inputs.
mssalvatore
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a part of #3078
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Do all end-to-end tests pass?If applicable, add screenshots or log transcripts of the feature working