OTP validation #3197
Merged
OTP validation #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyamalviya
force-pushed
the
3078-otp-validation
branch
from
7847327 to
a66e4c8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3197 +/- ##
==========================================
Coverage ? 73.05%
==========================================
Files ? 471
Lines ? 13585
Branches ? 0
==========================================
Hits ? 9924
Misses ? 3661
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mssalvatore
requested changes
Apr 5, 2023
monkey/monkey_island/cc/services/authentication_service/i_otp_repository.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/authentication_service/authentication_facade.py
Outdated
Show resolved
Hide resolved
cakekoa
reviewed
Apr 5, 2023
monkey/monkey_island/cc/services/authentication_service/mongo_otp_repository.py
Outdated
Show resolved
Hide resolved
So that similar methods are close to each other
This will prevent unnecessary encryption operations and speed up other operations in this repository.
The only mutable property on the OTP is whether or not it's been used. Limit the interface to allow mutating only this mutable property.
"called_once_with()" does not exist. It succeeds because mock mock objects allow you to call arbitrary methods.
mssalvatore
force-pushed
the
3078-otp-validation
branch
from
7cc0ac1 to
a6bc055
Compare
We want to avoid leaking secrets into the log.
cakekoa
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a part of #3078
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Do all end-to-end tests pass?If applicable, add screenshots or log transcripts of the feature working