-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3078 otp expiration timer #3200
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3200 +/- ##
===========================================
- Coverage 73.02% 72.97% -0.05%
===========================================
Files 469 471 +2
Lines 13566 13538 -28
===========================================
- Hits 9907 9880 -27
+ Misses 3659 3658 -1 see 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A video clip would help speed review along.
7dd721d
to
a94d30a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect the command to be refreshed automatically if it is expired. Maybe that is not something we want but as a user experience, I wouldn't want to click Refresh after the timer expires.
Also lets add pie as expiration timer, not numbers..
Screen.Recording.2023-04-06.at.11.11.34.AM.mov
if (minutes === 0 && seconds === 0) { | ||
return 'Command expired'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we regenerate the command and restart the timer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The useTimer
method allows one to register an onExpire
callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen.Recording.2023-04-06.at.7.38.29.AM.mov
+1 |
fe3161d
to
9cbefbf
Compare
e89988b
to
8e9c669
Compare
8e9c669
to
2f3b3ca
Compare
What does this PR do?
Fixes part of #3078 by displaying a countdown timer for the OTP expiration.
PR Checklist
Testing Checklist