Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNMP exploiter #3313

Merged
merged 5 commits into from
May 9, 2023
Merged

SNMP exploiter #3313

merged 5 commits into from
May 9, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented May 5, 2023 •
edited
Loading

What does this PR do?

Fixes part of #3234.

Implements the SNMP exploiter

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

mssalvatore
mssalvatore reviewed May 7, 2023
View reviewed changes
monkey/agent_plugins/exploiters/snmp/src/snmp_exploit_client.py Outdated
Comment on lines 93 to 100
# ObjectType(ObjectIdentity("NET-SNMP-EXTEND-MIB", 'nsExtendStatus', f'"{command_name}"')),
# ObjectType(ObjectIdentity("NET-SNMP-EXTEND-MIB", 'nsExtendOutput1Line', f'"{command_name}"')),
# ObjectType(ObjectIdentity("NET-SNMP-EXTEND-MIB", 'nsExtendOutputFull', f'"{command_name}"')),
# ObjectType(ObjectIdentity("NET-SNMP-EXTEND-MIB", 'nsExtendOutNumLines', f'"{command_name}"')),
ObjectType(
ObjectIdentity("NET-SNMP-EXTEND-MIB", "nsExtendResult", f'"{command_name}"')
),
# ObjectType(ObjectIdentity("NET-SNMP-EXTEND-MIB", 'nsExtendOutLine', f'"{command_name}"')),
Copy link
Collaborator

@mssalvatore mssalvatore May 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to call this out before these get deleted. These should be mentioned in a comment so that we don't forget they're available to us if we need them in the future.

@cakekoa cakekoa changed the title TEMP: Partial work on SNMP exploiter SNMP exploiter May 8, 2023
@cakekoa cakekoa marked this pull request as ready for review May 8, 2023 15:04
@cakekoa cakekoa mentioned this pull request May 8, 2023
Merged
10 tasks
@mssalvatore mssalvatore merged commit 9739ff0 into develop May 9, 2023
@mssalvatore mssalvatore deleted the 3234-exploiter branch May 9, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakekoa @mssalvatore