Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNMP options #3324

Closed
wants to merge 8 commits into from
Closed

SNMP options #3324

wants to merge 8 commits into from

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented May 8, 2023 •
edited
Loading

What does this PR do?

Fixes part of #3234.
Merge after #3323.

Adds options for SNMP exploiter

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by running the plugin with the exploiter_plugin_runner

  • If applicable, add screenshots or log transcripts of the feature working

@cakekoa cakekoa changed the title 3234 options SNMP options May 8, 2023
@cakekoa cakekoa force-pushed the 3234-exploit-client branch from 96e7a50 to 80c2256 Compare May 9, 2023 16:03
shreyamalviya
shreyamalviya reviewed May 10, 2023
View reviewed changes
monkey/agent_plugins/exploiters/snmp/config-schema.json Outdated
"properties": {
"agent_binary_download_timeout": {
"title": "Agent binary download timeout",
"description": "The maximum time (in seconds) to wait for a successfully exploited SNMP client to download the agent binary.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "The maximum time (in seconds) to wait for a successfully exploited SNMP client to download the agent binary.",
"description": "The maximum time (in seconds) to wait for a successfully exploited SNMP client to download the Agent binary.",

@cakekoa cakekoa force-pushed the 3234-exploit-client branch from fb60bd1 to c689a6c Compare May 11, 2023 16:12
@cakekoa cakekoa force-pushed the 3234-options branch 2 times, most recently from 53872ec to d1a6ddf Compare May 11, 2023 17:07
@cakekoa cakekoa force-pushed the 3234-exploit-client branch from d8c830c to e28d2e0 Compare May 11, 2023 17:09
@cakekoa cakekoa force-pushed the 3234-exploit-client branch from e28d2e0 to 0043516 Compare May 11, 2023 17:16
@cakekoa cakekoa marked this pull request as ready for review May 11, 2023 18:39
mssalvatore added a commit that referenced this pull request May 11, 2023
@mssalvatore
Merge branch '3234-options' into develop
a5ec39e 
Issue #3234
PR #3324
@mssalvatore
Copy link
Collaborator

Merged in a5ec39e

@mssalvatore mssalvatore deleted the 3234-options branch May 11, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya left review comments

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cakekoa @mssalvatore @shreyamalviya