-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB: Add SNMP configuration to depth_1_a grouped tests #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija-lazoroski
added a commit
that referenced
this pull request
May 10, 2023
444a3dd
to
aacf612
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
May 15, 2023
aacf612
to
5cf36be
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
May 15, 2023
5cf36be
to
ad3f0fb
Compare
mssalvatore
reviewed
May 15, 2023
Comment on lines
39
to
42
"SNMP": { | ||
"agent_binary_download_timeout": 60, | ||
"snmp_request_timeout": 0.5, | ||
"snmp_retries": 3, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use the default.
Suggested change
"SNMP": { | |
"agent_binary_download_timeout": 60, | |
"snmp_request_timeout": 0.5, | |
"snmp_retries": 3, | |
}, | |
"SNMP": { | |
"snmp_request_timeout": 0.5, | |
"snmp_retries": 3, | |
}, |
Drop this down to 1 so that our tests don't take forever to run.
Suggested change
"SNMP": { | |
"agent_binary_download_timeout": 60, | |
"snmp_request_timeout": 0.5, | |
"snmp_retries": 3, | |
}, | |
"SNMP": { | |
"agent_binary_download_timeout": 60, | |
"snmp_request_timeout": 0.5, | |
"snmp_retries": 1, | |
}, |
ilija-lazoroski
added a commit
that referenced
this pull request
May 15, 2023
ad3f0fb
to
b83fe48
Compare
b83fe48
to
8fe1d96
Compare
mssalvatore
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #3234 .
Merge after the exploiter plugin is done and tested.
Add any further explanations here.
PR Checklist
Testing Checklist