Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB: Add SNMP configuration to depth_1_a grouped tests #3330

Merged
merged 1 commit into from
May 15, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes part of #3234 .

Merge after the exploiter plugin is done and tested.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

ilija-lazoroski added a commit that referenced this pull request May 10, 2023
@ilija-lazoroski ilija-lazoroski force-pushed the 3234-snmp-update-ete-configuration branch from 444a3dd to aacf612 Compare May 10, 2023 14:04
ilija-lazoroski added a commit that referenced this pull request May 15, 2023
@ilija-lazoroski ilija-lazoroski force-pushed the 3234-snmp-update-ete-configuration branch from aacf612 to 5cf36be Compare May 15, 2023 14:24
ilija-lazoroski added a commit that referenced this pull request May 15, 2023
@ilija-lazoroski ilija-lazoroski force-pushed the 3234-snmp-update-ete-configuration branch from 5cf36be to ad3f0fb Compare May 15, 2023 14:26
@ilija-lazoroski ilija-lazoroski marked this pull request as ready for review May 15, 2023 14:26
Comment on lines 39 to 42
"SNMP": {
"agent_binary_download_timeout": 60,
"snmp_request_timeout": 0.5,
"snmp_retries": 3,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use the default.

Suggested change
"SNMP": {
"agent_binary_download_timeout": 60,
"snmp_request_timeout": 0.5,
"snmp_retries": 3,
},
"SNMP": {
"snmp_request_timeout": 0.5,
"snmp_retries": 3,
},

Drop this down to 1 so that our tests don't take forever to run.

Suggested change
"SNMP": {
"agent_binary_download_timeout": 60,
"snmp_request_timeout": 0.5,
"snmp_retries": 3,
},
"SNMP": {
"agent_binary_download_timeout": 60,
"snmp_request_timeout": 0.5,
"snmp_retries": 1,
},

ilija-lazoroski added a commit that referenced this pull request May 15, 2023
@ilija-lazoroski ilija-lazoroski force-pushed the 3234-snmp-update-ete-configuration branch from ad3f0fb to b83fe48 Compare May 15, 2023 14:45
@mssalvatore mssalvatore force-pushed the 3234-snmp-update-ete-configuration branch from b83fe48 to 8fe1d96 Compare May 15, 2023 14:48
@mssalvatore mssalvatore merged commit f829039 into develop May 15, 2023
@mssalvatore mssalvatore deleted the 3234-snmp-update-ete-configuration branch May 15, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants