Polymorphism configuration #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
requested changes
May 16, 2023
shreyamalviya
commented
May 16, 2023
Comment on lines
+258
to
+259
| description="Emulate the property of polymorphic (or metamorphic) malware that all " | ||
| "copies have unique hashes by modifying the Agent binary before propagation.", |
There was a problem hiding this comment.
This description isn't showing up in the UI for some reason.
mssalvatore
reviewed
May 16, 2023
Comment on lines
+2
to
+11
| 'title': 'Polymorphism', | ||
| 'properties': { | ||
| 'randomized_agent_hash': { | ||
| 'title': 'Randomize Agent hash', | ||
| 'type': 'boolean', | ||
| 'default': false, | ||
| 'description': 'Emulate the property of polymorphic (or metamorphic) malware that all ' + | ||
| 'copies have unique hashes by modifying the Agent binary before propagation.' | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure how much of this is necessary at all. I've removed this locally, rebuilt, and seen no change in behavior. I've also done this for other parts of the configuration.
Most of the schema should be built from the config schema generated by the backend.
mssalvatore
force-pushed
the
3244-polymorphism-configuration-section
branch
from
8fc6254 to
53f35a7
Compare
|
@shreyamalviya I've merged this, as it's critical path and nothing can proceed without it. I've added a new task to the issue to resolve the description not showing up. But pay special attention to #3340 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a part of #3244
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Do all end-to-end tests pass?