Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3244 enable random hash in agent #3345

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented May 16, 2023

What does this PR do?

Issue #3244
Enables randomized binary hash in the agent.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by manually by running a single BB test and checking the hashes of the binaries.

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore mssalvatore force-pushed the 3244-enable-random-hash-in-agent branch from 4c57aeb to d40dea2 Compare May 16, 2023 15:17
Copy link
Contributor

@cakekoa cakekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. If we're happy with the level of testing that has been done then I think we're good to merge

@mssalvatore mssalvatore merged commit 1b20771 into develop May 16, 2023
@mssalvatore mssalvatore deleted the 3244-enable-random-hash-in-agent branch May 16, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants