Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3244 sha256 agent registration #3346

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented May 16, 2023

What does this PR do?

Fixes part of #3244.

Adds sha256 field to AgentRegistrationData

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@@ -17,6 +17,7 @@ class AgentRegistrationData(InfectionMonkeyBaseModel):
parent_id: Optional[UUID]
cc_server: SocketAddress
network_interfaces: Sequence[IPv4Interface]
sha256: str
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some validation to this. A validator that checks this against a regex should be sufficient, like r"[0-9a-f]{64}"

@cakekoa cakekoa mentioned this pull request May 16, 2023
10 tasks
@mssalvatore mssalvatore force-pushed the 3244-sha256-agent-registration branch from 224765f to b3a9507 Compare May 16, 2023 16:59
@mssalvatore mssalvatore merged commit 105fff2 into develop May 16, 2023
@mssalvatore mssalvatore deleted the 3244-sha256-agent-registration branch May 16, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants