3234 fix inconsistent value error #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
reviewed
May 22, 2023
| @@ -90,12 +93,24 @@ def exploit_host( | |||
|
|
|||
| def _exploit(self, target_ip: IPv4Address, community_string: str, command: str): | |||
| command_name = self._generate_command_name() | |||
| self._snmp_client.set_command(target_ip, command_name, community_string, command) | |||
| logger.debug(f"Executing SNMP command {command_name} on {target_ip}") | |||
| # self._try_set_command(target_ip, command_name, community_string, command) | |||
There was a problem hiding this comment.
Suggested change
| # self._try_set_command(target_ip, command_name, community_string, command) |
mssalvatore
requested changes
May 22, 2023
Comment on lines
100
to
102
| self._snmp_client.set_command(target_ip, command_name, community_string, command) | ||
| self._snmp_client.activate_command(target_ip, command_name, community_string) | ||
| self._snmp_client.execute_command(target_ip, command_name, community_string) | ||
| finally: | ||
| self._snmp_client.clear_command(target_ip, command_name, community_string) |
There was a problem hiding this comment.
I think set_command() and activate_command() should be encapsulated by create_command().
mssalvatore
force-pushed
the
3234-fix-inconsistent-value-error
branch
from
3afa0fc to
2be5d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3234.
PR Checklist
Testing Checklist