Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3411 fix getblocktemplate request #3580

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

mssalvatore
Copy link
Collaborator

What does this PR do?

Fixes the getblocktemplate request sent out by cryptojacker
Issue #3411

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Copy link
Contributor

@cakekoa cakekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it just needed to use the right encoding?

@mssalvatore
Copy link
Collaborator Author

So it just needed to use the right encoding?

Pretty much.

@mssalvatore mssalvatore force-pushed the 3411-fix-getblocktemplate-request branch from f3226bf to e771211 Compare August 10, 2023 18:25
@mssalvatore mssalvatore merged commit 4964f8c into develop Aug 10, 2023
@mssalvatore mssalvatore deleted the 3411-fix-getblocktemplate-request branch August 10, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants