Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashing passwords to make sure we don't log passwords plaintext #438

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Hashing passwords to make sure we don't log passwords plaintext #438

merged 3 commits into from
Sep 19, 2019

Conversation

ShayNehmad
Copy link
Contributor

Feature / Fixes

Fixes #434.

@ShayNehmad ShayNehmad added the Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. label Sep 18, 2019
@ShayNehmad ShayNehmad requested a review from VakarisZ September 18, 2019 07:40
@ShayNehmad ShayNehmad self-assigned this Sep 18, 2019
@danielguardicore
Copy link
Contributor

Please also hash hashes

VakarisZ
VakarisZ approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Daniel pointed out hashing hashes would also make sense. Create an issue for that probably.

@danielguardicore danielguardicore merged commit 8c69cc0 into develop Sep 19, 2019
@ShayNehmad ShayNehmad mentioned this pull request Sep 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

Assignees

@ShayNehmad ShayNehmad

Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SMB exploiter (and maybe others) shows plaintext passwords in logs
3 participants
@ShayNehmad @danielguardicore @VakarisZ