Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test_environment.py #576

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

ShayNehmad
Copy link
Contributor

@ShayNehmad ShayNehmad commented Mar 15, 2020

What is this?

Relates to #567.

Want to see the codecov.io bot recognize the improvement in coverage.

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

Proof that it works

image

Changes

Commit messages are enough

@ShayNehmad ShayNehmad added the QA Issues relating to Quality Assurance and testing label Mar 15, 2020
@ShayNehmad ShayNehmad added this to the 1.8.0 milestone Mar 15, 2020
@ShayNehmad ShayNehmad self-assigned this Mar 15, 2020
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #576 into develop will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #576      +/-   ##
===========================================
+ Coverage    55.85%   56.15%   +0.30%     
===========================================
  Files          104      105       +1     
  Lines         3572     3588      +16     
===========================================
+ Hits          1995     2015      +20     
+ Misses        1577     1573       -4     
Impacted Files Coverage Δ
...cessing/system_info_collectors/test_environment.py 100.00% <100.00%> (ø)
...y/processing/system_info_collectors/environment.py 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdeadf...f49c707. Read the comment docs.

@ShayNehmad ShayNehmad merged commit 8eab25e into develop Mar 16, 2020
@ShayNehmad ShayNehmad deleted the 567/add-unit-test-to-test-coverage-bot branch March 16, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Issues relating to Quality Assurance and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant