-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/random pep #636
Bugfix/random pep #636
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #636 +/- ##
===========================================
- Coverage 57.60% 57.58% -0.03%
===========================================
Files 116 116
Lines 3892 3890 -2
===========================================
- Hits 2242 2240 -2
Misses 1650 1650
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰
sock.send("start %s\r\n" % (cmdline,)) | ||
sock.send("net user %s /delete\r\n" % (self._config.user_to_add,)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will require testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that it's binary? I did a standalone test. socket.send indeed receives binary digits and not string. Or what sort of test did you have in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the exploiter still works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problematic, MonkeyZoo doesn't have a test for this
@ShayNehmad force pushed the branch and removed the MS08_67 code changes. |
…ernative is using __all__ but that may come with change in functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
What is this?
Doesn't fix anything but brings the number of flake8 warnings down to below 100.