Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/random pep #636

Merged
merged 6 commits into from
May 6, 2020
Merged

Conversation

acepace
Copy link
Contributor

@acepace acepace commented May 1, 2020

What is this?

Doesn't fix anything but brings the number of flake8 warnings down to below 100.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #636 into develop will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #636      +/-   ##
===========================================
- Coverage    57.60%   57.58%   -0.03%     
===========================================
  Files          116      116              
  Lines         3892     3890       -2     
===========================================
- Hits          2242     2240       -2     
  Misses        1650     1650              
Impacted Files Coverage Δ
monkey/infection_monkey/network/info.py 25.45% <ø> (ø)
monkey/infection_monkey/transport/__init__.py 100.00% <ø> (ø)
monkey/monkey_island/cc/environment/test_aws.py 100.00% <ø> (ø)
monkey/monkey_island/cc/models/test_monkey.py 100.00% <ø> (ø)
...nkey/monkey_island/cc/resources/bootloader_test.py 100.00% <ø> (ø)
...onkey/monkey_island/cc/services/bootloader_test.py 100.00% <ø> (ø)
monkey/monkey_island/cc/services/config_schema.py 100.00% <ø> (ø)
monkey/monkey_island/cc/services/node.py 30.31% <ø> (ø)
...nkey_island/cc/services/utils/bootloader_config.py 100.00% <ø> (ø)
...onkey_island/cc/services/utils/node_states_test.py 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ec436...115cb05. Read the comment docs.

Copy link
Contributor

@ShayNehmad ShayNehmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Comment on lines 244 to 245
sock.send("start %s\r\n" % (cmdline,))
sock.send("net user %s /delete\r\n" % (self._config.user_to_add,))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will require testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that it's binary? I did a standalone test. socket.send indeed receives binary digits and not string. Or what sort of test did you have in mind?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the exploiter still works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problematic, MonkeyZoo doesn't have a test for this

@acepace acepace force-pushed the bugfix/random_pep branch from 1160429 to 4c27ea4 Compare May 5, 2020 20:47
@acepace
Copy link
Contributor Author

acepace commented May 5, 2020

@ShayNehmad force pushed the branch and removed the MS08_67 code changes.
Please merge.

Copy link
Contributor

@ShayNehmad ShayNehmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@ShayNehmad ShayNehmad merged commit d502154 into guardicore:develop May 6, 2020
@acepace acepace deleted the bugfix/random_pep branch May 11, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants