Schedule jobs bugfix #861
Schedule jobs bugfix #861
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #861 +/- ##
========================================
Coverage 60.52% 60.53%
========================================
Files 165 165
Lines 4948 4949 +1
========================================
+ Hits 2995 2996 +1
Misses 1953 1953
Continue to review full report at Codecov.
|
VakarisZ
force-pushed
the
schedule_jobs_bugfix
branch
from
5356ab4 to
7abafb7
Compare
| reply = requests.get(url, timeout=7) | ||
| except requests.exceptions.RequestException: | ||
| logger.info("Can't get latest monkey version, probably no connection to the internet.") | ||
| raise NoInternetError |
There was a problem hiding this comment.
This might result from lack of internet connection, but also if our update server fails to respond for some reason.
I would change the exception to something like UpdateServerUnreachableException
I think the term "update server" better describes the server than "version server", but it's more important to stay consistent. So either change the rest of the variable names here to "update server" or call the exception VersionServerUnreachableException
| @@ -20,3 +20,7 @@ class CredentialsNotRequiredError(RegistrationNotNeededError): | |||
|
|
|||
| class AlreadyRegisteredError(RegistrationNotNeededError): | |||
| """ Raise to indicate the reason why registration is not required """ | |||
|
|
|||
|
|
|||
| class VersionServerConnectionError(Exception): | |||
There was a problem hiding this comment.
Should be part of this PR?
There was a problem hiding this comment.
Probably not, but since this is a small refactoring on separate commits, I think it's fine
What does this PR do?
Fixed 2 issues:
PR Checklist
Testing Checklist