Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux deployment scripts tweaks #900

Merged
merged 12 commits into from
Dec 9, 2020
Merged

Linux deployment scripts tweaks #900

merged 12 commits into from
Dec 9, 2020

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Dec 8, 2020 •
edited
Loading

What does this PR do?

Fixes a number of issues with deployment_scripts/deploy_linux.sh.

The deployment_scripts/deploy_linux.sh is not often used. As such, it has fallen into a state of disrepair. These commits fix a number of installation failures, as well as update some documentation to improve the overall experience of using the linux deployment script.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the deploy_linux.sh script on an Ubuntu 18.04 VM

  • If applicable, add screenshots or log transcripts of the feature working

msal-guardicore and others added 11 commits December 8, 2020 09:58
@msal-guardicore
Check if user is root before starting deploy_linux script
330ad65 
If the user is root, we want to exit as soon as possible since any commands
that the deployment script runs will be run as root.
@msal-guardicore
Fix hung timeout when checking for sudo in deploy_linux.sh
6f0fffe
@msal-guardicore
Give a more descriptive error message if deploy_linux.sh cannot use sudo
0238354
@VakarisZ @msal-guardicore
Fixed linux deployment script config to point to proper repository
88c7a6a
@VakarisZ @msal-guardicore
Fixed linux deployment script config syntax
b84d1f1
@msal-guardicore
Enable deployment_scripts/config to use wget or curl
c807104
@msal-guardicore
Install python3-distutils in deploy_linux.sh
39da129
@msal-guardicore
Make create_certificate.sh executible when deploying on linux
cdc6515
@msal-guardicore
Install libcurl4 in deploy_linux.sh
66ac438
@msal-guardicore
Assume yes for apt install commands in deploy_linux.sh
ce40392
@msal-guardicore
Add instructions on how to run monkey_island after deploy_linux.sh
2111d2a
acepace
acepace reviewed Dec 8, 2020
View reviewed changes
Copy link
Contributor

@acepace acepace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use apt as it has an unstable CLI interface.
https://manpages.debian.org/buster/apt/apt.8.en.html#SCRIPT_USAGE_AND_DIFFERENCES_FROM_OTHER_APT_TOOLS

Other than that, changes look good.

@mssalvatore
Copy link
Collaborator Author

mssalvatore commented Dec 8, 2020 •
edited
Loading

We should not use apt as it has an unstable CLI interface.

@acepace Good call. I'll push a fix tomorrow.

@msal-guardicore
Switch from apt install to apt-get install in deploy_linux.sh
5401cf2 
`apt-get` has a stable command-line interface, while `apt` does not.
@mssalvatore mssalvatore merged commit 44fd1ab into guardicore:develop Dec 9, 2020
@supkisids50 supkisids50 mentioned this pull request Jan 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acepace acepace acepace left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mssalvatore @acepace @msal-guardicore @VakarisZ