-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Normalize repository, dropping node <10.13 support #239
Conversation
I'll make a PR for using |
@sttk why did you remove support for gulp 3.x? This package is supposed to support all versions of gulp we can. |
@phated Since |
@phated I've modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since gulp-cli is added dependencies of gulp, gulp-cli is not needed to install globally and we can think that new gulp-cli is used in new gulp.
The purpose of this is to allow the node_modules/.bin/gulp
to be placed when having the gulp
dependency, but we don't want users to be installing gulp
globally. Instead the gulp-cli
project should be installed globally and needs to support each version of gulp.
In addition, it's difficult that we'll continue to support gulp v3 on new node and new versions of dependencies.
We can update dependencies and node versions while still supporting gulp 3 and gulp 4. The versioned
directory allows for us to have isolated code for each one. Please restore the gulp 3 support in this PR.
Additionally, I was trying to review this PR but it seems like you renamed and moved files around without much purpose. Can you reduce this PR to the dependency upgrades/changes and normalization for an easier review? We can add follow up PRs that refactor.
@@ -114,7 +114,7 @@ Supported configurations properties: | |||
| flags.gulpfile | Set a default gulpfile | | |||
| flags.silent | Silence logging by default | | |||
| flags.series | Run tasks given on the CLI in series (the default is parallel) | | |||
| flags.require | An array of modules to require before running the gulpfile. Any relative paths will be resolved against the `--cwd` directory (if you don't want that behavior, use absolute paths) | | |||
| flags.preload | An array of modules to preload before running the gulpfile. Any relative paths will be resolved against the `--cwd` directory (if you don't want that behavior, use absolute paths) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Include this rename in the conventional commits so it shows in changelog
215a0d1
to
225beb0
Compare
@phated I've reverted the two commits about dropping old gulp supports and changing directory configuration. Please review this PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sttk! This is excellent work. I had a few questions and comments that I'd like addressed.
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
@phated I've done except the matter regarding |
@phated All changes have been completed. Please review this PR again. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes here @sttk! I have a few more comments, but this is nearly completed 🎉
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
@phated I've modified what you pointed out. Please review again. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive thank you @sttk for all your work here! This PR turned out excellent. ❤️
This PR updates this repository for the following points:
Upgrades dependencies and drops node <10.13 support
yargs
's version is 16, not latest, because the latest version 17 supports node >=12.marked-man
version is 0.7, because the latest version 1.3 is esm.eslint
,expect
, andmocha
upgrades to the last versions which supports node v10.Stops using
gulp-test-tools
Because
gulp-test-tools
was used for nodejs v0.10.Replaces
ansi-color
andcolor-suuport
tochalk
Because this package used
chalk
originally, andchalk
enables to drop the codes for--color/--no-color
flags.Drops
isobject
andarray-sort
By adding alternative codes.
Drops old gulp supports
This PR removes
^3.7.0
,^4.0.0-alpha.1
, and^4.0.0-alpha.2
directories.Change directory configuration.