Fix pandoc metadata check #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, discount didn't like empty metadata. Either they are all present or not. Anyhow yes, your fix makes sense! |
|
What will happen if the document had 4 lines with % ? This seems to be
accepted and the 4th line goes into the output unprocessed
…On Wed, 7 Apr 2021, 07:49 Fabio Cevasco, ***@***.***> wrote:
Yes, discount didn't like empty metadata. Either they are all present or
not. Anyhow yes, your fix makes sense!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK42NEL7HBVTQPTDD6QPHTTTHPW67ANCNFSM42O3ZREA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed problems when one of the first 3 lines of the document was empty. Then the check for
%character failed. Additionally the whole content of the file was split into lines and then merged. I think it is more efficient to just truncate the beginning of the file. As thesparameter is notvarI couldn't usedeletewhich would change the input so the substring of the input is created. I wasn't also sure why this was done, I assume that Discount was not able to handle it correctly if not all three lines started with%.