-
Notifications
You must be signed in to change notification settings - Fork 100
Conversation
r? |
Fixed static lifetimes Reviewed-by: bgamari
@farcaller am I mistaken in thinking that bors expects approvals to be of the form |
bors allows that only from collaborators. Fixed that for you and @errordeveloper ;-) |
Another one thing that I cannot reproduce, and this code doesn't even touch PT!
|
Ok, so this is nightly fallout in nightly fallout fix. Looking into it... |
Breakage investigation so far: parser's Replaced with Now, I have absolutely no idea, what's happening in there, filed rust-lang/rust#15931 |
Did a bisect and small investigation, rust-lang/rust#15972. |
Filed rust-lang/rust#15973. |
r? 😄 |
Fixing a bunch of nightly fallouts Reviewed-by: bgamari
@@ -8,6 +8,8 @@ install: | |||
- tar xf rust.tgz | |||
- (cd ./rust-nightly-x86_64-unknown-linux-gnu/; sudo ./install.sh) | |||
- export LD_LIBRARY_PATH=/usr/local/lib | |||
- (mkdir -p ./thirdparty; cd ./thirdparty; git clone --depth 50 https://github.com/rust-lang/rust) | |||
- "(cd ./thirdparty/rust; git checkout `rustc --version|awk '{sub(/\\(/, \"\", $3); print $3}'`)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This fixes lifetimes broken by lifetime elision.
Cleaning up lifetimes is tracked in #115.
Also fixed rlib dependency tracker, an issue with broken PT if compiled with -O2. Libcore version is now matched to rustc version to prevent any compilation failures.