Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate api client and refactor http request #121

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 11, 2024

使用 halo-sigs/halo-gradle-plugin#16 提供的 api client 生成方法生成 http 请求客户端代码,并重构插件的请求逻辑。

/kind improvement

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 11, 2024 04:06
@ruibaby ruibaby requested a review from LIlGG August 11, 2024 04:06
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
Copy link

f2c-ci-robot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 4db48c9 into halo-sigs:main Aug 27, 2024
2 checks passed
@ruibaby ruibaby deleted the refactor/generate-api-client branch August 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants