fix: access the list interface without logging in #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/bug
JohnNiang
added
the
kind/api-change
JohnNiang
requested changes
Feb 21, 2024
LIlGG
force-pushed
the
fix/access-control-invalid
branch
from
82d8b3d to
3e40679
Compare
guqing
approved these changes
Feb 21, 2024
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
根据 自定义 API 的规则，当 group 为
api.<group>时，此接口默认为为主题端公开的接口。而 moment 在初始定义时，使用了api.plugin.halo.run作为 group，因此导致其能被公开访问。本 pr 将 moment 自定义的接口组由
api.plugin.halo.run改为console.api.moment.halo.run，用于解决用户未登录便可访问瞬间列表的问题。How to test it?
未登录状态下，直接访问接口
/apis/console.api.moment.halo.run/v1alpha1/moments。 查看是否提示无权限。Which issue(s) this PR fixes:
Fixes #71
Does this PR introduce a user-facing change?