Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: optimize the ui in moment editing mode #83

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 21, 2024

What type of PR is this?

/kind improvement

What this PR does / why we need it:

优化编辑状态下的瞬间列表样式

How to test it?

测试瞬间整体功能未发生变化即可。

Does this PR introduce a user-facing change?

优化编辑状态下的瞬间列表样式

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen February 21, 2024 09:59
@guqing
Copy link
Member

guqing commented Feb 21, 2024

标签筛选功能好像不正确啊

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

筛选条件与上面编辑器的边距加大一点与会不会更合理毕竟筛选是作用于列表的
image

@guqing
Copy link
Member

guqing commented Feb 21, 2024

建议在没有数据展示空状态时可以占满高度

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
Copy link

f2c-ci-robot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2fa8a84 into halo-sigs:main Feb 22, 2024
1 check passed
@LIlGG LIlGG deleted the pref/optimize-moment-editing branch February 22, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants