Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hole free marks #29

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Hole free marks #29

merged 2 commits into from
Feb 20, 2025

Conversation

smoores-dev
Copy link
Contributor

ProseMirror doesn't actually require holes in mark output specs!

https://prosemirror.net/docs/ref/#model.MarkSpec.toDOM

When the resulting spec contains a hole, that is where the marked content is placed. Otherwise, it is appended to the top node.

This updates the OutputSpec component so that it automatically inserts the hole for marks at the top level, matching the prosemirror-view implementation

Verified

This commit was signed with the committer’s verified signature.
smoores-dev Shane Friedman

Verified

This commit was signed with the committer’s verified signature.
smoores-dev Shane Friedman
@smoores-dev smoores-dev requested review from tilgovi and a team as code owners February 20, 2025 20:51
@smoores-dev smoores-dev merged commit ee1fda0 into main Feb 20, 2025
2 checks passed
@smoores-dev smoores-dev deleted the hole-free-marks branch February 20, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant