Plugin automatically selects first item from library

[atomashevic]

Reference selection/picker menu does not appear after I either run "Insert citation" or "Open literature note" command.

It automatically chooses the first Zotero item in my JSON file and inserts link or open new literature note.

OS: Ubuntu 20.04
Obsidian: v0.9.22 (deb installer)

Previously (and in previous vault) I used snap version of Obsidian and Citation plugin and selection menu did appear, but nothing happened afterwards. Then I removed the snap version, installed deb and created a new vault.

[raineszm]

I'm also seeing this issue.

OS: MacOS 11.1
Obsidian: v0.10.1 (installer 0.9.22)

No errors in the console, although the active leaf appears to be printed.

[hans]

Hi both, thanks for the report! Can you please confirm you're on the latest version of the plugin (0.3.0) ?

[raineszm]

Yes. This is on 0.3.0.

[xldenis]

I'm also getting this issue on the latest version!

[atomashevic]

Just to confirm, it's latest version (0.3.0).

[hans]

Hmm, I can't reproduce this bug, even with the same Obsidian version and plugin version. Would one of you be willing to share your citation library export?

[raineszm]

Hmm, I can't reproduce this bug, even with the same Obsidian version and plugin version. Would one of you be willing to share your citation library export?

I'd be happy to provide an exported JSON file. I see the problem with my full library which is about 900 items but also with a smaller subset.

Exported Items.json.txt

[atomashevic]

Here's a smaller subset of my library where I have the same issue.

https://filebin.net/a89izm7wwvd4t8qm

Thanks!

[hans]

I'm still failing to reproduce this even with your citation libraries, but I'll try again on a totally clean VM install and keep you posted.

[raineszm]

This issue appears to be this event handler

obsidian-citation-plugin/src/modals.ts

Line 24 in 7ae7513

this.inputEl.addEventListener("keyup", (ev) => this.onInputKeyup(ev));

I think that when calling these functions from the command palette, the event handler is getting the key up of the command submission and immediately submitting the modal. This aligns with the fact that things work fine if I use the assigned hotkeys instead of calling from the command palette.

Edit:
Commenting this line out causes the prompt to appear as expected. Out of curiosity, do you usually run the command using the hotkeys?

[hans]

@raineszm Thanks a lot for tracking this down. I realize just now that I didn't understand the problem in the first place — I was taking "run command" to mean "run the command via hotkey."

This should be an easy fix -- I'll fix this later today.

[hans]

Fixed & will be shipped with the next release, coming very soon. Thanks everyone for pitching in :)