ALSA: ali5451: remove irq enabling in pointer callback

evdenis · tiwai · commit dacae5a19b4c · 2013-02-11T16:52:46.000+01:00
snd_ali_pointer function is called with local
interrupts disabled. However it seems very strange to
reenable them in such way.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov &lt;yefremov.denis@gmail.com&gt;
Cc: &lt;stable@vger.kernel.org&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)
 
 	spin_lock(&codec->reg_lock);
 	if (!pvoice->running) {
-		spin_unlock_irq(&codec->reg_lock);
+		spin_unlock(&codec->reg_lock);
 		return 0;
 	}
 	outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));

Original file line number	Diff line number	Diff line change
`@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)`
`1435`	`1435`
`1436`	`1436`	`spin_lock(&codec->reg_lock);`
`1437`	`1437`	`if (!pvoice->running) {`
`1438`		`- spin_unlock_irq(&codec->reg_lock);`
	`1438`	`+ spin_unlock(&codec->reg_lock);`
`1439`	`1439`	`return 0;`
`1440`	`1440`	`}`
`1441`	`1441`	`outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));`