Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] vsphere-iso bugfix invalid conf device 2 issue https://github.… #10631

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2021

bug fix : for vsphere-iso builder issue : #10430
when specifying more than one disk in the template configuration it now gives the error: Invalid configuration for device '2'

Closes 10430

@ghost ghost self-requested a review as a code owner February 14, 2021 11:57
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #10631 (ae4a33b) into master (b20dea6) will not change coverage.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
builder/vsphere/driver/disk.go 0.00% <0.00%> (ø)

@azr azr marked this pull request as draft February 15, 2021 14:02
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there. Do you plan to keep working on this?

@ghost
Copy link

ghost commented Apr 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 19, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants