Fix highlighting of .0, .* attribute access and [*] brackets
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it a valid HCL syntax as expressions cannot stand alone in the body.
This makes it a valid HCL syntax as expressions cannot stand alone in the body.
radeksimko
force-pushed
the
fix-dot-digit-notation
branch
from
ef03581 to
1bd2804
Compare
radeksimko
changed the title
.0 and .* notations.0, .* attribute access and [] brackets
radeksimko
changed the title
.0, .* attribute access and [] brackets.0, .* attribute access and [*] brackets
This was referenced Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
After I started looking more closely at the existing tests I realised there is a few more bugs beyond what's described in #40
This fixes handling of the following expressions:
attribute.0)attribute.*)attribute[*])The PR is best reviewed commit-by-commit, especially because I updated some of the test data to make them more accurate, as per #43 (comment)
Before / After
HCL
Terraform