Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to match terraform-aws-vault-enterprise-hvd/pull/21/files #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix to match terraform-aws-vault-enterprise-hvd/pull/21/files #10

wants to merge 1 commit into from
+3 −3

Conversation

abuxton
Copy link
Contributor

@abuxton abuxton commented Mar 18, 2025

Description

fix to match terraform-aws-vault-enterprise-hvd/pull/21/files

Related issue

[Link to the related issue (if applicable)]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How has this been tested?

  • [Describe the tests you ran to verify your changes]
  • [Provide any results or outcomes from the tests]
  • [Include any additional notes related to the tests]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional notes

[Add any additional information or context about the PR here]

Sorry, something went wrong.

@abuxton abuxton requested a review from a team March 18, 2025 11:02
tristanmorgan
tristanmorgan approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@tristanmorgan tristanmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanmorgan tristanmorgan

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abuxton @tristanmorgan