Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes for template #8

Merged
merged 2 commits into from
Mar 6, 2025
Merged

small fixes for template #8

merged 2 commits into from
Mar 6, 2025

Conversation

jessicaahm
Copy link
Contributor

@jessicaahm jessicaahm commented Mar 5, 2025

Description

[Provide a brief description of the changes in this PR]

Related issue

[Link to the related issue (if applicable)]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How has this been tested?

  • [I ran it in my environment]
  • [Provide any results or outcomes from the tests]
  • [-i is needed when you have input files]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional notes

There are not much changes here, only small fixes for template and the add of telemetry.

Copy link

hashicorp-cla-app bot commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

@abuxton abuxton requested a review from a team March 5, 2025 10:22
@abuxton abuxton requested review from a team and abuxton March 6, 2025 11:14
@abuxton abuxton changed the title small fixes for template and added telemetry small fixes for template Mar 6, 2025
Copy link
Contributor

@thejohnny thejohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roooms roooms merged commit 567ec75 into hashicorp:main Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants