Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default filters to remove more timestamps #32

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

liamcervante
Copy link
Member

This removes any elapsed_seconds fields, and removes the @message field from apply_complete message in the apply JSON output.

This should help with the flaky tests such as hashicorp/terraform#36172. Anything with timestamps is subject to the whims of the computer, and can't really be included.

@liamcervante liamcervante requested a review from a team as a code owner December 10, 2024 09:28
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look through the PR (and the codebase as it's my first time) and I can see how these changes are all needed. Other than an additional test case I've requested I'm happy to approve the PR

@liamcervante liamcervante merged commit a935610 into main Dec 12, 2024
4 checks passed
@liamcervante liamcervante deleted the liamcervante/timestamps branch December 12, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants