Make all paths supplied by flags absolute #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
This PR makes the
--goldens
and--tests
flag values be converted to absolute paths before they're used. This avoids the problem described in the linked issue.I also changed how the path to the Terraform binary is made absolute, so that it's consistent. The function filepath.Abs is implemented pretty much the same way as the code that's being replaced:
I'm unsure of any pitfalls around converting paths to absolute paths, which is the main thing I'd like to address during review. E.g. usage on non-unix machines?