Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and update CODEOWNERS #10

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Move and update CODEOWNERS #10

merged 1 commit into from
Mar 20, 2025

Conversation

roooms
Copy link
Collaborator

@roooms roooms commented Mar 19, 2025

Description

Move CODEOWNERS to correct location to match the module template

Related issue

[Link to the related issue (if applicable)]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How has this been tested?

Matches template and other HVD module's structure

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional notes

We have changed the team in CODEOWNERS from hvd-module-review to hvd-module-approvers. This will eventually be fixed with template sync, but for now, where a PR moves the CODEOWNERS file to the correct location it may also fix the team in the same commit if possible/necessary.

@roooms roooms requested review from abuxton and ml4 March 19, 2025 10:32
Copy link
Contributor

@abuxton abuxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@jeffmccollum jeffmccollum self-requested a review March 19, 2025 14:15
@abuxton abuxton merged commit 7bb568f into main Mar 20, 2025
2 checks passed
@abuxton abuxton deleted the move-codeowners branch March 20, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants