Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: decode deprecated ignoreDirectoryNames & warn #1009

Merged
merged 1 commit into from
Jul 22, 2022
Merged

settings: decode deprecated ignoreDirectoryNames & warn #1009

merged 1 commit into from
Jul 22, 2022

Conversation

radeksimko
Copy link
Member

This is just a small addition to #1003 to make the warning clearer.

Before

Screenshot 2022-07-21 at 11 09 20

After

Screenshot 2022-07-21 at 11 12 48

@radeksimko radeksimko added enhancement New feature or request technical-debt labels Jul 21, 2022
@radeksimko radeksimko added this to the v0.29.0 milestone Jul 21, 2022
@radeksimko radeksimko self-assigned this Jul 21, 2022
@radeksimko radeksimko marked this pull request as ready for review July 21, 2022 10:14
@radeksimko radeksimko requested a review from a team as a code owner July 21, 2022 10:14
dbanck
dbanck approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 922d187 into main Jul 22, 2022
@radeksimko radeksimko deleted the f-deprecated-option-catch branch July 22, 2022 09:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@radeksimko radeksimko

Labels
enhancement New feature or request technical-debt
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @dbanck