Add GitHub Action to add binaries to new release #16
Conversation
jrhouston
force-pushed
the
github-action-release-binary
branch
from
c3604c5 to
6a94abd
Compare
| for asset in ./release-bin/*.zip; do | ||
| assets+=("-a" "$asset") | ||
| done | ||
| hub release create "${assets[@]}" -m "${{ github.ref }}" "${{ github.ref }}" |
There was a problem hiding this comment.
Got this from here: actions/upload-release-asset#28 (comment)
Looks like there isn't an easy way to glob for assets yet.
|
Looks good, let's not do any work to upload to releases.hashicorp.com yet though, we don't want the alpha provider automatically appearing on the registry. |
Yep, that should still be handled by the regular release process when we set that up. |
scripts/build_release_binaries.sh
Outdated
| mkdir -p $ASSETS_DIR | ||
| rm -rf $ASSETS_DIR/* | ||
|
|
||
| for osarch in $OS_ARCH; do |
There was a problem hiding this comment.
This looks like it does exactly what it should.
For the sake of conversation, wanted to mention the gox tool.
Hashicorp projects have been using https://github.com/mitchellh/gox to implement cross-building. Gox does all the builds in parallel (depending on how many cores are available), among other things. Any pro / cons for picking one or the other?
There was a problem hiding this comment.
Oh I actually didn't know about this tool - this was just the simplest thing I could think of. I can just update the script to use this.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Adds a GitHub action to build and upload the binaries for all OS + architectures when a new semver tag is pushed - this was a manual task in the old provider.
Partly solves #9