-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to parse backend blocks present in a test file's run blocks, validate configuration #36541
Conversation
…t use the same internal state file. Update tests.
…lock. Update tests.
… for same state key.
We only need to consider one file at a time when checking if a state_key already has a backend associated with it; parallelism in `terraform test` is scoped down to individual files.
8ba13c0
to
5ee3d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're not checking anywhere that only the first run block for a given state can
Edit by Sarah : Need to check that the run with the the backend is the first apply command for that internal state
…apply command for an internal state
State keys aren't being set in time for validating use of backend blocks yet
…key set at parsing time
…dule state keys are in use
The latest changes have:
|
Sorry for the back and forth here! Previously I thought the different ordering that impacted the acceptance test were due to new behaviour in the test graph, but it was just due to iterating over a map 🤦🏻 . I've addressed that in 75dfe43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing that last bit 🫡
Thanks both! 🙇🏻 |
Description
This PR is the first step of adding support for backend blocks to run blocks in
terraform test
:Luckily we can reuse the existing code for parsing backend blocks, so validation is the main problem being addressed in this PR.
Validation requirements