Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Remove use of actions/cache, which conflicts with caching done by actions/setup-go into v1.11 #36640

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 5, 2025

Backport

This PR is auto-generated from #36571 to be assessed for backporting due to the inclusion of the label 1.11-backport.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@SarahFrench
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/terraform/merges: 409 refusing to allow a GitHub App to create or update workflow .github/workflows/checks.yml without workflows permission []

The below text is copied from the body of the original PR.


Fixes the errors we see in GHAs like this:

Screenshot 2025-02-24 at 18 52 37

It looks like v4 of the actions/go-setup GHA enables caching by default, so when the action was updated to use a v4+ version of that action it started clashing with actions/cache.

This PR removes use of actions/cache and instead uses the caching features of go-setup. Internally this uses the same logic (actions/cache is used) but requires fewer inputs.

This matches what's already done in the equivalence test workflows, so a cache will be shared between more GHA workflows after this PR.

Target Release

N/A

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

Overview of commits

Copy link

hashicorp-cla-app bot commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

This comment was marked as resolved.

@SarahFrench SarahFrench marked this pull request as ready for review March 5, 2025 12:01
SarahFrench
SarahFrench previously approved these changes Mar 5, 2025
@SarahFrench SarahFrench self-requested a review March 5, 2025 12:01
@SarahFrench SarahFrench force-pushed the backport/fix-gha-go-cache-errors/briefly-amazing-crow branch from c63e80d to accb637 Compare March 5, 2025 12:02
@SarahFrench SarahFrench requested a review from a team as a code owner March 5, 2025 12:02
@SarahFrench SarahFrench enabled auto-merge (squash) March 5, 2025 12:03
@SarahFrench SarahFrench merged commit 8762ca8 into v1.11 Mar 5, 2025
6 of 7 checks passed
@SarahFrench SarahFrench deleted the backport/fix-gha-go-cache-errors/briefly-amazing-crow branch March 5, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants